Add basic Dockerfile #4
Conversation
rblaine95
force-pushed
the
dockerfile
branch
3 times, most recently
from
6494858
to
b055f57
Compare
Dockerfile
Outdated
|
|
||
| EXPOSE 3000 | ||
|
|
||
| ENTRYPOINT [ "tini", "--", "node", "./build/main.js" ] |
There was a problem hiding this comment.
I noticed that, when using ENTRYPOINT [ "node", "./build/main.js" ], I couldn't send a SIGINT to the node process (CTRL+C) successfully.
Hence wrapping it in tini which handles signals and reaps zombie processes (if there ever are any zombie processes in the future)
rblaine95
force-pushed
the
dockerfile
branch
3 times, most recently
from
0628202
to
3734a43
Compare
|
Tilt gives you a web interface with logs and live reloading docker containers on code change (and more) |
rblaine95
force-pushed
the
dockerfile
branch
3 times, most recently
from
27279a8
to
05c87e5
Compare
|
Hi @rblaine95. Great additions 👍 We just need to make the PR to the I'm afraid that if we merge this to |
|
Sure thing @jakubkoci, I've updated the base of the PR and will do a quick rebase. |
* Add basic Dockerfile
* Add `.tool-versions` for `asdf`/`rtx`
* Extend `.gitignore`
* Add vscode extensions recommendations
* Add `.prettierignore` to ignore the `build/` directory
* Build `node_modules` early in Docker image for more efficient caching
* Use `tini` as entrypoint to catch signals
* I noticed when not using `tini`, I couldn't `SIGINT` the node
process
asdfg
* Add `NODE_ENV` to Dockerfile * Remove build from docker-compose as Tilt was already building * Change docker entrypoint and command * Re-organize dependencies in `package.json` * Many dev dependencies are actually just dependencies * Reduce Docker image size by splitting Dev/Prod
| FROM docker.io/node:18-alpine | ||
|
|
||
| USER 0 | ||
| RUN apk add --update --no-cache tini curl |
There was a problem hiding this comment.
I added a commit with signal handlers to this PR which is a good practice in Node.js apps in general. We shouldn't need tini with them.
I usually tend to lower deps in Docker as much as possible, but if you feel it's still beneficial having tini I'm happy with that :)
There was a problem hiding this comment.
Tini is exceptionally small (±68KB)
The main benefits of tini is that:
- Reaping of zombie processes (I've seen some docker images that benefit from this)
- Signal handling
- Fully transparent
krallin/tini#8 has a good writeup on benefits of using it.
| { | ||
| "files.trimFinalNewlines": true, | ||
| "files.insertFinalNewline": true | ||
| } |
There was a problem hiding this comment.
This should be solved by the Prettier formatter. You can check and update the format with the following commands:
yarn format:check
yarn format:update
Doesn't it work for you? I'll add some pre-push hooks that will check the format and linter rules before each push to the repo.
There was a problem hiding this comment.
Prettier does work for me, but I like to add these settings with vscode as it executes whenever you save the file
There was a problem hiding this comment.
WRT git hooks, I've worked with Husky in the past
| } | ||
| ) | ||
|
|
||
| docker_compose('docker-compose.yaml') |
There was a problem hiding this comment.
I haven't heard of the Tilt yet. Sounds cool 👍
There was a problem hiding this comment.
Think docker compose up but on steroids
.tool-versionsforasdf/rtx.gitignoredocker-compose.yamland TiltfileI tried to do a multi-stage Docker build, but the build output depends on the
node_modules/directory.Partially resolves #1